Bug 4154 - [ecs] make ECS_MAX_TREESIZE configurable
[ecs] make ECS_MAX_TREESIZE configurable
Status: RESOLVED FIXED
Product: unbound
Classification: Unclassified
Component: server
unspecified
All All
: P5 enhancement
Assigned To: unbound team
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-09-12 08:36 CEST by Manu Bretelle
Modified: 2018-10-23 04:24 CEST (History)
2 users (show)

See Also:


Attachments
[ecs] make ECS_MAX_TREESIZE configurable (6.89 KB, patch)
2018-09-12 08:36 CEST, Manu Bretelle
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manu Bretelle 2018-09-12 08:36:07 CEST
Created attachment 523 [details]
[ecs] make ECS_MAX_TREESIZE configurable

Currently, the radix tree holding the records for a given qtype/qclass/qname is limited to a set size of 100 nodes.

This limits the effectiveness of the cache as after 100 queries with different subnets, items are being evicted from the cache.


https://github.com/chantra/unbound/commit/0666078e6a75836cc36d54085dbba8184509b2ac

provides a patch to make both v4 and v6 caches customizable.
Comment 1 Wouter Wijngaards 2018-10-22 16:55:40 CEST
Hi Manu,

Incorporated the patch!

Best regards, Wouter
Comment 2 Manu Bretelle 2018-10-23 04:24:03 CEST
great! Thanks Wouter!