Bug 3451 - dnstap not building when you have a separate build dir
dnstap not building when you have a separate build dir
Status: RESOLVED FIXED
Product: unbound
Classification: Unclassified
Component: server
1.6.8
x86_64 Linux
: P5 normal
Assigned To: unbound team
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2018-02-02 14:42 CET by John Dickinson
Modified: 2018-02-05 13:15 CET (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Dickinson 2018-02-02 14:42:14 CET
/usr/bin/protoc-c --c_out=. ../dnstap/dnstap.proto
../dnstap/dnstap.proto: File does not reside within any path specified using --proto_path (or -I).  You must specify a --proto_path which encompasses this file.  Note that the proto_path must be an exact prefix of the .proto file names -- protoc is too dumb to figure out when two paths (e.g. absolute and relative) are equivalent (it's harder than you think).
Makefile:391: recipe for target 'dnstap/dnstap.pb-c.c' failed
make: *** [dnstap/dnstap.pb-c.c] Error 1
Comment 1 Wouter Wijngaards 2018-02-05 13:15:41 CET
Hi John,

Fixed it, in code repository, and patch below if you need that.

Best regards, Wouter

Index: Makefile.in
===================================================================
--- Makefile.in	(revision 4503)
+++ Makefile.in	(working copy)
@@ -389,7 +389,7 @@
 
 dnstap/dnstap.pb-c.c dnstap/dnstap.pb-c.h: $(srcdir)/dnstap/dnstap.proto
 	@-if test ! -d dnstap; then $(INSTALL) -d dnstap; fi
-	$(PROTOC_C) --c_out=. $(srcdir)/dnstap/dnstap.proto
+	$(PROTOC_C) --c_out=. --proto_path=$(srcdir) $(srcdir)/dnstap/dnstap.proto
 
 dnstap.pb-c.lo dnstap.pb-c.o: dnstap/dnstap.pb-c.c dnstap/dnstap.pb-c.h
 
Index: dnstap/dnstap.proto
===================================================================
--- dnstap/dnstap.proto	(revision 4503)
+++ dnstap/dnstap.proto	(working copy)
@@ -13,6 +13,7 @@
 // with this file. If not, see:
 //
 // <http://creativecommons.org/publicdomain/zero/1.0/>.
+syntax = "proto2";
 
 package dnstap;